Hi Jonathan,

sorry for the late answer. (I'm not always that bad). We still develop this
and try to use it for a project. Our main
concern in the moment is performance. Purescript is slow in some basic
functionality, and when you try to work
with webgl it is common that you need a performant solution.

So I see that you want to make thinks better, but if the performance gets
worse I will in no way follow it.

So if you e.g. can make the webgl-examples examples run on the changed
implementation we could compare.

Generally I'm happy someone contributes, so I hope we find a way to join
forces.

Best regards
Jürgen

2015-05-27 22:34 GMT+02:00 Jonathan Childress [email protected]:

Hello! I don't know if you're actively developing this now, but if you
are, I would love to know your thoughts on modifications in my fork. I'm a
rookie at contributing to FOSS— in the future I'll definitely separate the
changes.

The major changes present are:

• cleaning up the parser/generator Haskell code
• splitting the output into separate modules for easier use
• requiring the WebGLContext as the first argument for every WebGL
  method
• packaging the PureScript output with the generator (as it seems this
  should be a standalone PureScript library)

I know this includes major breaking changes, but if any of these sound
useful to you I'd be happy to collaborate on merging them. Otherwise I have
a slightly different direction I'd like to take the WebGL library that sits
upon the raw output— a Graphics.WebGL.Unsafe that provides type-safety
(but not error-handling) and finally a WebGLT monad transformer that
passes the context to each function and wraps error handling for each
method call.

Thanks!

You can view, comment on, or merge this pull request online at:

#4
Commit Summary

• cleanup .cabal and Main.hs files
• Git should ignore cabal sandboxes
• clean up AST
• cleanup IDL parser (needs testing)
• fix redundancy and src file
• WIP
• first pass at cleaning PrettyPrinter works
• ugly printer but good output
• now printing impl functions rather than nested
• correctly print array types
• remove typedef from constants
• arbitrary cleanup
• additional cleanup
• rm accidentally-committed test file
• remove unused isUsableFunction
• rearrange as both cabal and bower packages
• add more package files
• added a basic README
• significant cleanup
• additional cleanup
• minor edits
• add typesig to constants for doc generation
• split output in multiple files for easier use
• correctly print function export list
• export non-impl functions for easier usage
• print WebGL enums as camelCase
• significant README edits
• bump version to 0.2.0

File Changes

• M .gitignore
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-0
  (6)
• A README.md
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-1
  (52)
• D WebGL.idl
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-2
  (739)
• A bower.json
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-3
  (19)
• A docs/README.md
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-4
  (3259)
• R docs/WebGL-1.0.3.idl
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-5
  (3)
• A generator/IDL/AST.hs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-6
  (68)
• A generator/IDL/Parser.hs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-7
  (187)
• A generator/IDL/Printer.hs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-8
  (220)
• A generator/Main.hs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-9
  (36)
• A gruntfile.js
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-10
  (32)
• A package.json
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-11
  (16)
• D purescript-webgl-generator.cabal
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-12
  (21)
• A purescript-webgl-raw.cabal
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-13
  (22)
• A src/Graphics/WebGL/Raw.purs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-14
  (1607)
• A src/Graphics/WebGL/Raw/Enums.purs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-15
  (908)
• A src/Graphics/WebGL/Raw/Types.purs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-16
  (40)
• D src/IDL/AST.hs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-17
  (60)
• D src/IDL/Parser.hs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-18
  (119)
• D src/IDL/Printer.hs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-19
  (142)
• D src/Main.hs
  https://github.com/jutaro/purescript-webgl-generator/pull/4/files#diff-20
  (43)

Patch Links:

• https://github.com/jutaro/purescript-webgl-generator/pull/4.patch
• https://github.com/jutaro/purescript-webgl-generator/pull/4.diff

—
Reply to this email directly or view it on GitHub
#4.

Thanks for replying! Do you have any examples of some of the performance bottlenecks you've experienced? I'd love to create some test benchmarks to see what impact any changes have had.